Attention is currently required from: neels, pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )

Change subject: cp_peer: Implement local originated heartbeat procedure
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1: 
one might have moved/extracted the header  file in a separate patch, that would 
have saved me some confusion reading the diff from top to bottom, wondering why 
the copyright statement is by neels while you are the author of the commit, and 
the content being generic and unrelated to heartbeat ;)



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I7efc0961e1ea39dd7f4cc6ba96be4cf5ce9a2d6c
Gerrit-Change-Number: 42120
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 14 Feb 2026 10:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to