Attention is currently required from: Hoernchen, laforge, osmith, pespin.

fixeria has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )

Change subject: octsim: initial commit
......................................................................


Patch Set 5:

(2 comments)

File octsim/OCTSIM_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/a5958ae8_6ba5cea5?usp=email
 :
PS4, Line 81: function f_st_drain() runs on test_CT {
> what's the purpose of this function? I think it requires some documentation. 
> […]
`ST.clear` and `ST_IRQ.clear` then.


File octsim/OCTSIM_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/df4d0e8c_a3ac6cf4?usp=email
 :
PS5, Line 146: private altstep as_st_irq_wait_flags(template (present) 
CardEmu_StatusFlags exp_flags) runs on test_CT {
formatting needs to be fixed here



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 17 Feb 2026 08:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to