Attention is currently required from: Hoernchen, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email )
Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 2: (2 comments) File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/c190ca42_c667c0bd?usp=email : PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */ > the fixme or the lines above? […] The FIXME. https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/0d64220e_2f50506d?usp=email : PS2, Line 178: CRITICAL_SECTION_ENTER(); > yes, for dfu_download_offset and to ensure `dfu_flash_done = true` isn't set > without dfu_flash_statu […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 10:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
