Attention is currently required from: Hoernchen, laforge, lynxis lazus.
Hello Jenkins Builder, laforge, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge
Change subject: dfu: do not reset itself
......................................................................
dfu: do not reset itself
In theory USB_DFU_ATTRIBUTES_WILL_DETACH is nice, in practice
not so much, because usb uses control transfers and "waiting" for
status response completion after finishing flashing is cumbersome.
There is basically no advantage if the device resets itself, and
just waiting for the host to do it like most DFU devices
(and what the BL used to do in the beginning) works
around the status issue.
Right now dfu-utils is unhappy because the final get status never is answered
because the response is submitted by the device, but the self reset immediately
afterwards is faster, so it never arrives at the host.
Change-Id: I1b9e48470083597640918a8a1126922b31150153
---
M usb/class/dfu/device/dfudf_desc.h
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/80/42180/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153
Gerrit-Change-Number: 42180
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
