Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email )
Change subject: stream: Improve error handling and logging in write_cb
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> alternatively, if we submitted a write of zero bytes length, then that's also
> an error in the applic […]
Actually a write(count=0) is an expected correct scenario, see man 2 write:
```
If count is zero and fd refers to a regular file, then write() may return a
failure status if one of the errors below is detected. If no errors are
detected, or
error detection is not performed, 0 is returned without causing any
other effect. If count is zero and fd refers to a file other than a regular
file, the results
are not specified.
```
Also, currently stream_cli and stream_srv are handling that part different, so
for sure we want to unify the behavior there...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb
Gerrit-Change-Number: 42191
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 24 Feb 2026 15:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
