Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email )
Change subject: RTP: make ortp optional at compile time
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
I see these 2 ORTP references, but they are probably wrong and can be dropped
since they should come from libosmo-netif pkgcfg if needed:
src/osmo-bts-oc2g/Makefile.am
17: $(ORTP_CFLAGS) \
29: $(ORTP_LIBS) \
Do you mind submitting an extra patch dropping them? I can do it myself but I
don't want to interfere with your changes.
File contrib/ber/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/71258ed1_67d4e696?usp=email
:
PS2, Line 1: if ENABLE_ORTP
Add this to the parent Makefile to conditionally add it to SUBDIR so this file
is not even processed?
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/7c27856c_c8f7bf61?usp=email
:
PS2, Line 406: {
you don't really need {} afaict, we are enforcing -std=gnu11 during build in
configure.ac?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1
Gerrit-Change-Number: 42197
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Comment-Date: Wed, 25 Feb 2026 09:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
