Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email )
Change subject: dfu: mainloop: work on a local copy of dfu_state ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > ok, so I think we agree this is not neccessary after all? Given that all > loads/stores are atomic, a […] AFAIU: Pau asked if this assignment itself is atomic (last_dfu_state = dfu_state) and if not would need a CRITICAL section, where we agreed, the assignment itself is atomic. About this assignment, I want to make sure the mainloop would loop over and only does one thing based based on the dfu_state. Trying to keep the code path simple and keep away from side effects. Otherwise a loop run could run through different states and does multiple things -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ic146c8fa5ba25425cf785bae66f9c99b0faab944 Gerrit-Change-Number: 42170 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 11:30:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
