Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email )
Change subject: fix --disable-log-macros
......................................................................
fix --disable-log-macros
Before 9197c1ac, the AC_ARG_ENABLE(log_macros, ...)
action was hardcoded to [log_macros="yes"], so *any*
use of the flag --enable-log-macros or --disable-log-macros
would set log_macros="yes" -> AC_DEFINE([LIBOSMOCORE_NO_LOGGING]).
The commit changed this to the standard [log_macros=$enableval], but
broke the conditional test, so
- AC_ARG_ENABLE sets $enableval to "no" for --disable-* flags
-> log_macros is now "no"
-> test fails
-> LIBOSMOCORE_NO_LOGGING is never defined...
The opposite of what it should do...
Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/42203/1
diff --git a/configure.ac b/configure.ac
index b32f304..e3201b3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -507,7 +507,7 @@
[--disable-log-macros],
[Disable logging macros that are also used internally to print
information]
)],
- [log_macros=$enableval],
[log_macros=$ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT])
+ [log_macros="yes"], [log_macros=$ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT])
if test x"$log_macros" == x"yes"
then
AC_DEFINE([LIBOSMOCORE_NO_LOGGING],[1],[Disable logging macros])
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
