Attention is currently required from: Hoernchen, fixeria, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > ..but just hoping people don't just use HAVE_XX and don't include config. […] if we add such a check to libosmocore gerrit build verification, then I am happy to accept the need for config.h include in every source file. The difference to HAVE_XX is that if you use somtehing like that as a developer, you should know from past work experience that you need config.h. But needing it just because you're using libosmocore logging is somewhat unusual and hard to remember. And someone will forget about it, and we will see the issue reappear. I'm 100% sure. Checking in another repo will not prevent breaking changes from being introduced to libosmocore. So whatever we do in terms of checking, it must be done within this repo and its CI. I do believe we're doing an embedded arm-none-eabi build in the verification, and maybe we can add your check there? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
