Attention is currently required from: Hoernchen, dexter, jolly, lynxis lazus.

laforge has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email )

Change subject: ccid_device: Reject XfrBlock with zero-length data
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> When using your patch, the bankd will close the connection, because pcsc fail 
> the transaction.
well, that is then how pcscd + the application deals with it, fine.  If they 
want to deal with it differently, it's up to then. From the firmware/protocol 
point of view, returning a dwLength error looks like the right thing to do?  Or 
do you have a different idea/understanding?  Asking since you didn't +1 it yet.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8
Gerrit-Change-Number: 42192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-CC: dexter <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 26 Feb 2026 15:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to