Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/4a7d4106_167e361a?usp=email : PS2, Line 29: vo > it's still inconsistent with how we do it in libasn1c So your proposal then iiuc would be to leave the tcap_talloc_asn1_ctx public as extern, and then let eg. osmo-stp (stp_main.c) define it? -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
