Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email )
Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length ...................................................................... Patch Set 3: (1 comment) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/64496dbc_3fe793be?usp=email : PS3, Line 826: return -107; > (unresolv it) The most likely explanation for a short TPDU is that the cardem/tracer somehow failed to correctly receive/decode the command from the modem, possibly due to timing, EMI or a firmware bug or the like. Well, it's hard to know what is desirable here. If any one APDU in a sequence of APDUs fails, there is no way to know if the state is still consistent. Imagine a SELECT before an UPDATE - you end up writing to the wrong file. So I think failing fast and fully is a safe approach, rather than simply ignoring errors. But I'm happy to be convinced otherwise... -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I5c9f1143b85470234acd2e2ffe3e0cf72bd2ae43 Gerrit-Change-Number: 42231 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
