osmith has submitted this change. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: Fix lint errors: test for membership should be `not in`
......................................................................
Fix lint errors: test for membership should be `not in`
src/osmocom/tlv.py:477:16: E713 [*] Test for membership should be `not in`
|
475 | key-value pair, where the key is the snake-reformatted type name
of 'self'"""
476 | expected_key_name = camel_to_snake(type(self).__name__)
477 | if not expected_key_name in decoded:
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E713
478 | raise ValueError("Dict %s doesn't contain expected key %s" %
(decoded, expected_key_name))
479 | self.from_val_dict(decoded[expected_key_name])
|
= help: Convert to `not in`
Change-Id: I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd
---
M src/osmocom/tlv.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
laforge: Looks good to me, approved
osmith: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/src/osmocom/tlv.py b/src/osmocom/tlv.py
index 93e4e87..14c22f0 100644
--- a/src/osmocom/tlv.py
+++ b/src/osmocom/tlv.py
@@ -474,7 +474,7 @@
This method is symmetrical to to_dict() above, i.e. the outer dict
must contain just a single
key-value pair, where the key is the snake-reformatted type name of
'self'"""
expected_key_name = camel_to_snake(type(self).__name__)
- if not expected_key_name in decoded:
+ if expected_key_name not in decoded:
raise ValueError("Dict %s doesn't contain expected key %s" %
(decoded, expected_key_name))
self.from_val_dict(decoded[expected_key_name])
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd
Gerrit-Change-Number: 41386
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
