Attention is currently required from: Hoernchen. osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email )
Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The approach I've taken with checkpatch (from linux.git) and how it is configured for Osmocom repositories is, that it should only complain about things that are clearly wrong. So it should rather *not* complain about something that may be right or may not be, than annoy the users with unhelpful errors. This is now working in what seems like 95% of all cases or so (I'm subscribed to the "lint errors" jenkins feed and checking regularly if it is complaining for wrong reasons and look into it, adjust it as it makes sense). Could you configure clang-format to do this too? Otherwise we might want to reconsider if clang-format is a good fit for our linting requirements. I'd also be interested in what advantages clang-format gives you. There are some downsides to having two tools, they will probably always disagree on some things, we need to maintain an additional config and the reporting isn't inline as gerrit comments when compared to how we have it set up for checkpatch now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: lynxis lazus <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 07:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
