Patch Set 4: (2 comments)
And do we really need to test logging here? It's already being tested in libosmocore, so testing here for me seems useless... https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am File CommonLibs/Makefile.am: Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) We already have both VTY and CTRL cflags here, so do we really need to duplicate? https://gerrit.osmocom.org/#/c/6620/4/tests/CommonLibs/Makefile.am File tests/CommonLibs/Makefile.am: Line 4: AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) The same question here... -- To view, visit https://gerrit.osmocom.org/6620 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30baac89f53e927f8699d0586b43cccf88ecd493 Gerrit-PatchSet: 4 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
