Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42741?usp=email )
Change subject: pySim/global_platform: make functionality available outside of cmd2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I don't really like the approach to expose lots of functions at the module that are not part of some kind of object-oriented code / classes. This looks like C code and quite un-pythonic to me, and I think we need a better architecture for this. It's almost like the pySim.commands.SimCardCommands what we're adding here. We possibly need something more modular where differnt modules (like global_platform here) can implement (and register?) a class containing methods for various commands? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idf4e4b58bf49ba62b2c22de4c49a2dcacfa872cb Gerrit-Change-Number: 42741 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 19:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
