Attention is currently required from: fixeria, neels.

laforge has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/40208?usp=email )

Change subject: personalization: implement UppAudit and BatchAudit
......................................................................


Patch Set 11: Code-Review+1

(1 comment)

File pySim/esim/saip/batch.py:

https://gerrit.osmocom.org/c/pysim/+/40208/comment/92da3694_f3fa7ccd?usp=email :
PS11, Line 143: {'001010000000023'}
why is a set returned? and if a set is returned, to what do multiple instances 
relate? If this is about an EF.IMSI in multiple NAA (like one USIM and one 
ISIM) then I think the NAA should be named rather than assuming any implicit 
ordering.  Theoretically a eSIM profile could also contain multiple instances 
of a USIM NAA, as far as I can tell.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40208?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaab336ca91b483ecdddd5c6c8e08dc475dc6bd0a
Gerrit-Change-Number: 40208
Gerrit-PatchSet: 11
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 08 May 2026 08:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to