Attention is currently required from: daniel, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email )

Change subject: Radical reduce the asn1 code to the essential parts
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> AFAIU if our ASN1 files are the same as the ones in wireshark, so in that 
> case if asn1c fails to dec […]
Yes, parts of the asn1 files were taken from wireshark. But wireshark decodes 
it different (over multiple files) and in the end decodes it correct.

I could try to fix the asn1 files, but because we don't need it and we should 
not take a such deep look into the packet from the TCAP routing case, I reduced 
it.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42746?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: Ib8afe0dbe8d4436b80c71048f3b572fcda6cd33e
Gerrit-Change-Number: 42746
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 14 May 2026 06:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to