Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email )
Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... Patch Set 3: (6 comments) Patchset: PS3: > why is VTY tests failing here? please explain. Answer in the thread above. PS3: > /unresolv it. The vty tests fails, because I'm adding a new command which contains more characters than all previous valid commands, which adds more indention to the help message. But I can't change the expected output to contain more spaces, because than this would fails when not compiling with tcap loadsharing. Only one of the build checks fails here Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/dc3afb20_338fa7ea?usp=email : PS3, Line 19: Defaults to reject-utds. > udts (everywhere you wrote it) I was very consistent and wrote it everywhere the wrong way. will fix it. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/f27bc9b0_873ebb16?usp=email : PS3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback) > Having this param here only to tick a rate_ctr look weird tbh, I'd rather > move this to the caller, a […] ok, will change it. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/05064a26_273f32d7?usp=email : PS3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) > else if (as->cfg.loadshare.tcap. […] Acknowledged https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/9b29106c_06f58781?usp=email : PS3, Line 556: asp = select_asp_tcap_enabled_rr(as, true); > shouldn't we be adding a track_entry here (move the call above here) so that > when an Abort/End for t […] yes, you're right. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Sat, 23 May 2026 07:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
