Attention is currently required from: laforge, lynxis lazus, neels, osmith.
Hello Jenkins Builder, daniel, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith
Change subject: osmo_interact: improve vty transcript language by a regular
rexex
......................................................................
osmo_interact: improve vty transcript language by a regular rexex
Currently the transcript language understand 3 different tokens:
... (ignore all lines until the following line matches)
... !REGEX (ignore all lines except REXEX)
But to support osmo-stp with different compile options, the
vty help is indented with different amount of spaces depending on the compile
options.
To support those add a regular regex using the prefix !r!
E.g.
```
OsmoSTP(config-cs7-as)# ?
- description Save human-readable description of the object
vs
+ description Save human-readable description of the object
```
To use the new regex, the line would be:
```
!r! description[ ]+Save human-readable description of the object
```
Further all regex special characters needs to be escaped.
```
description Save human-readable description of the object (for humans)
!r! description[ ]+Save human-readable description of the object \(for humans\)
```
Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
---
M osmopy/osmo_interact/common.py
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests
refs/changes/62/42762/2
--
To view, visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/42762?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iadcd7a8c3677548a6405e098fe53d0614ef2012c
Gerrit-Change-Number: 42762
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
