Attention is currently required from: Hoernchen, dexter, laforge, neels.

osmith has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/42625?usp=email )

Change subject: osmo-smdpp.py: use commonpath in transversal check
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Patchset:

PS1:
> The fix is literally commonprefix -> commonpath, but the LLM security spam 
> didn't even get that righ […]
Done


File osmo-smdpp.py:

https://gerrit.osmocom.org/c/pysim/+/42625/comment/82a72bd5_b29a5d63?usp=email :
PS1, Line 644:                 if not 
pathlib.Path(path).resolve().is_relative_to(self.upp_dir):
> I got the hint that resolving self. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a42b40aa2bbcd5f0ec99f172503354c6eaa9828
Gerrit-Change-Number: 42625
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 01 Jun 2026 06:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to