lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email )
Change subject: tcap loadshare: count all ENOKEY as a FAILED
......................................................................
tcap loadshare: count all ENOKEY as a FAILED
The ASP should count all message which couldn't routed as failed.
Related: SYS#5432
Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8
---
M src/tcap_as_loadshare.c
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
daniel: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c
index 5cc7d44..1a5d0ff 100644
--- a/src/tcap_as_loadshare.c
+++ b/src/tcap_as_loadshare.c
@@ -528,7 +528,6 @@
} else {
/* Couldn't find a suitable canditate */
LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a
suitable canditate for TCAP Begin otid %u\n", parsed.otid);
- rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED);
rc = -ENOKEY;
goto out_free_sua;
}
@@ -574,6 +573,9 @@
break;
}
out_free_sua:
+ if (rc == -ENOKEY)
+ rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED);
+
/* RFC3868 4.7.3: "If an ASP is not available, the SG may generate
(X)UDTS "routing failure",
* if the return option is used."
* See also ITU Q.714 4.2 */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8
Gerrit-Change-Number: 42756
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
