Attention is currently required from: fixeria, laforge.

tempest has posted comments on this change by tempest. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email )

Change subject: trx-usrp1: make single daughterboard VTY configurable
......................................................................


Patch Set 4:

(1 comment)

File CommonLibs/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/c8044c99_7bd09da1?usp=email
 :
PS2, Line 643:  if (strcmp("disable", argv[0]) == 0)
             :          trx->cfg.usrp1_singledb = false;
             :
             :  if (strcmp("enable", argv[0]) == 0)
             :
> ```suggestion […]
looks good, was following the formatting of the other enable/disable options in 
trx_vty.c but this works too



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0
Gerrit-Change-Number: 42811
Gerrit-PatchSet: 4
Gerrit-Owner: tempest <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 02 Jun 2026 19:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to