Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email )

Change subject: Add test case to verify proper DSCP settings
......................................................................


Patch Set 7:

(2 comments)

File tests/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/b5cb4f5c_493b4c03?usp=email
 :
PS7, Line 1: SUBDIRS = xua m2ua ss7 vty dscp
AFAIU the vty test will now use the binary from dscp directory, hence dscp 
needs to go before it: "dscp vty".


File tests/testsuite.at:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/b6e9dfbc_b7a9196b?usp=email
 :
PS7, Line 32: AT_CHECK([python3 -u 
$abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p 
$abs_srcdir -v TestDSCP],, [ignore], [ignore])
Why not launching automatically as part of tests/vty/Makefile.am, see target 
"vty-python-test"?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092
Gerrit-Change-Number: 42809
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 03 Jun 2026 13:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to