Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email )

Change subject: Add DSCP configuration support for each individual ASP
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

File src/ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808/comment/545a796b_8a89a45c?usp=email
 :
PS7, Line 388:  if (fd < 0)
if asp->cfg.is_server is false and asp->client is NULL; you are accessing an 
uninitialized variable fd here.
Set fd to -1 in line 378.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494
Gerrit-Change-Number: 42808
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jun 2026 20:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to