Patch Set 1: Code-Review-1

The problem is not spotted by libosmocore build job not having a dependency to 
osmocom-bb, i.e. we don't try to rebuild osmocom-bb when new code enters 
libosmocore. This must be fixed in jenkins job-builder. Created 
https://osmocom.org/issues/2985 for this

I guess we have to revert the libosmocore change.  While it logically is 
correct to have the function there, the problem is that the legacy gsm48* 
functions don't have the osmo_ prefix which we by now generally use for librray 
symbols :/

-- 
To view, visit https://gerrit.osmocom.org/6679
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c83ad0624839ce42864c70396a4397b21f514
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: No

Reply via email to