Attention is currently required from: dexter, jolly.
fixeria has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email )
Change subject: config/sys.config: fix certificate paths
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Usually all misc files go to the `priv` directory - this is a standard place
for auxiliary files in OTP applications. Its path can be obtained at run-time
via `code:priv_dir/1`:
```
-spec get_priv(Name) -> Path
when Name :: file:filename_all(),
Path :: file:filename_all().
get_priv(Name) ->
PrivDir = code:priv_dir(?ENV_APP_NAME),
filename:join(PrivDir, Name).
%% example
Path = get_priv("sample_ssl_cert.crt").
```
The proposed patch looks wrong to me.
The configuration should definitely not contain relative paths.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e
Gerrit-Change-Number: 42830
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 16 Jun 2026 07:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
