Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email )
Change subject: server: fix misleading data length validation log message ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42838/comment/2e1bf368_1f12ab5b?usp=email : PS1, Line 9: The format string "%u < %u <= %u" was printed with arguments : (min_len, data->len, max_len), placing the offending length in : the middle and mislabeling it. This is confusing. Let's print : the actual length followed by the expected interval instead. Hm, I actually think it's quite obvious the way it was. Reading the message I woould have assumed the minimum and maximum are left and right, plus the message actual length int he center. Doesn't make any sense otherwise. We can of course merge the patch, but I think it is something I'd like to call "sideways development" as I don't really think it moves us forward. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e Gerrit-Change-Number: 42838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
