Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email )
Change subject: tls: fix broken certificate hostname verification ...................................................................... Patch Set 1: (1 comment) File src/osmo_tls.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42849/comment/88c29c57_b0d358d3?usp=email : PS1, Line 529: sess->tls_hostname = client->tls_hostname; can client be freed here somehow while sess keeps being valid and hence sess->tls_hostname ends up pointing to a freed string? I'd rather do a talloc_strdrup() here to make the code more robust. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384 Gerrit-Change-Number: 42849 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:17:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
