Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email )

Change subject: osmo-bts-trx: shut down on stale clock indication from 
transceiver
......................................................................


Patch Set 1:

(2 comments)

File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42851/comment/b47fc0e8_f3d78cc0?usp=email
 :
PS1, Line 586:           * (elapsed_fn < 0) while far more wall-clock time 
elapsed than its FN
AFAIU "elapsed_fn < 0" is not a "FN far BEHIND our local timer", but a " FN 
BEHIND our local timer". Note how I remove the "far" bit.


https://gerrit.osmocom.org/c/osmo-bts/+/42851/comment/17fe27d7_d49718b4?usp=email
 :
PS1, Line 597:                  osmo_timerfd_disable(&tcs->fn_timer_ofd);
why do we need to disable this timerfd here?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If787ab7ed70aa2dcb0389ceb58620c2302c3431a
Gerrit-Change-Number: 42851
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 19 Jun 2026 16:28:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to