Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email )
Change subject: vty: clamp configured snaplen to the wire-framing limit ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: Fine about the osmo-pcap wire framing. I wonder: Is the snaplen also used in the IP over IP setup which iirc can also be used instead of the osmo-pcap wire framing? If that's the case, then there's no limit of uint16_t afaiu? File include/osmo-pcap/common.h: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/6618c9fd_8f4c11a0?usp=email : PS1, Line 70: #define OSMO_PCAP_MAX_SNAPLEN 65535 can we then set it to UINT16_MAX here? File src/osmo_client_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/b05d7768_c9780b6d?usp=email : PS1, Line 202: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n") Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/2ca37155_3d09d879?usp=email : PS1, Line 377: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n") Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ia56cad48e8cefe8ae103f2f7d2e037bf28438b71 Gerrit-Change-Number: 42836 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:38:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
