Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email )

Change subject: osmo-bts-trx: reset BTS GSM time on clock (re)start
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42850/comment/a40f2d0c_682b1c90?usp=email
 :
PS1, Line 499:  gsm_fn2gsmtime(&bts->gsm_time, 0);
> Don't we have the same problem on other BTS models?

Probably. But the problem is that only osmo-bts-trx has an explicit epoch hook 
`trx_sched_clock_started()` called on `POWERON`, while the others don't expose 
an equivalent "clock (re)started" signal. And honestly, I don't even know if 
other models reset their clock/time (TDMA Fn) after power-cycling the DSP.

> Shouldn't this be put in some more generic code path?

Generic path would likely be `l1sap_info_time_ind()` in `l1sap.c`. But at this 
level there exists no signal/primitive about the clock state. We don't even 
know if the L1 is powered on or not...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id8da126e460d3846a3be5bdb271553457fdd0590
Gerrit-Change-Number: 42850
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 19 Jun 2026 21:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to