Attention is currently required from: laforge, neels. fixeria has uploaded a new patch set (#10) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/40829?usp=email )
The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: param_source: use random.SystemRandom as random nr source ...................................................................... param_source: use random.SystemRandom as random nr source Python's random module uses a PRNG (Mersenne Twister) which is utterly insecure for key generation - it was so far only used for testing. Replace it with random.SystemRandom(), which draws from /dev/urandom and is suitable for generating cryptographic key material. Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa Jenkins: skip-card-test --- M pySim/esim/saip/param_source.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/40829/10 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa Gerrit-Change-Number: 40829 Gerrit-PatchSet: 10 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]>
