Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email )
Change subject: asn1/SGP32Definitions: upgrade ASN.1 spec to V.1.2 ...................................................................... Patch Set 1: (59 comments) File asn1/SGP32Definitions.asn1: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/6ab6a1d7_66e7f0fa?usp=email : PS1, Line 33: associationToken [4] INTEGER OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/df07f91c_744fdb3a?usp=email : PS1, Line 37: } OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/2fd276db_56ca41ba?usp=email : PS1, Line 91: seqNumber [0] INTEGER trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/63f7ded9_2681744f?usp=email : PS1, Line 114: euiccPackageResultDataSigned EuiccPackageResultDataSigned, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/1ef585e9_2e8c83b0?usp=email : PS1, Line 125: enableResult [3] EnableProfileResult, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/fe481aa0_c57db6ed?usp=email : PS1, Line 126: disableResult [4] DisableProfileResult, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/05873358_810e25f8?usp=email : PS1, Line 127: deleteResult [5] DeleteProfileResult, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/872c04e7_bc2ef18c?usp=email : PS1, Line 128: listProfileInfoResult [45] ProfileInfoListResponse, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/431f5ebe_fdf87ad9?usp=email : PS1, Line 147: euiccPackageErrorDataSigned EuiccPackageErrorDataSigned, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/06d0b00e_21ea61fa?usp=email : PS1, Line 198: returnFallbackProfile(21), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/3e6ab785_5315b0f3?usp=email : PS1, Line 207: profileChangeOngoing (11), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/95f85862_38379f5f?usp=email : PS1, Line 211: ok(0), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/615ae323_10dd359e?usp=email : PS1, Line 213: } trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/a06133c5_a28a6234?usp=email : PS1, Line 225: commandError(7), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/0550209b_40361e72?usp=email : PS1, Line 245: commandError(7), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/15b6cfc2_4893f47e?usp=email : PS1, Line 271: } trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/afa2dfe8_04835e10?usp=email : PS1, Line 313: ISDRProprietaryApplicationTemplateIoT ::= [PRIVATE 1] SEQUENCE { -- Tag 'E1' trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/3ae8e359_3de5ec4d?usp=email : PS1, Line 383: EUICCInfo2 ::= [34] SEQUENCE { -- Tag 'BF22' trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/53f04437_5338adba?usp=email : PS1, Line 384: profileVersion [1] VersionType, -- Base eUICC Profile package version supported trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/75d1a1a4_9fae854d?usp=email : PS1, Line 386: euiccFirmwareVer [3] VersionType, -- eUICC Firmware version trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/dd54a368_9b56b0ea?usp=email : PS1, Line 387: extCardResource [4] OCTET STRING, -- Extended Card Resource Information according to ETSI TS 102 226 trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/2e2e060b_d5648bff?usp=email : PS1, Line 388: uiccCapability [5] UICCCapability, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/b76a2933_4b9e28fb?usp=email : PS1, Line 389: ts102241Version [6] VersionType OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/051703d8_e05aa65a?usp=email : PS1, Line 390: globalplatformVersion [7] VersionType OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/b6a247fb_6a99cac0?usp=email : PS1, Line 391: rspCapability [8] RspCapability, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/cac51aae_c067599a?usp=email : PS1, Line 392: euiccCiPKIdListForVerification [9] SEQUENCE OF SubjectKeyIdentifier, -- List of CI Public Key Identifiers supported on the eUICC for signature verification trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/987adc47_3c3209b8?usp=email : PS1, Line 393: euiccCiPKIdListForSigning [10] SEQUENCE OF SubjectKeyIdentifier, -- List of CI Public Key Identifier supported on the eUICC for signature creation trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/b36179a6_ec928576?usp=email : PS1, Line 394: euiccCategory [11] INTEGER { trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/11813b86_b834d44f?usp=email : PS1, Line 395: other(0), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/81d94e87_f2ef1e69?usp=email : PS1, Line 396: basicEuicc(1), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/0fce2f2a_969fb1c3?usp=email : PS1, Line 397: mediumEuicc(2), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/c8c59725_360509b5?usp=email : PS1, Line 398: contactlessEuicc(3) trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/172bcaa4_4e38bdfa?usp=email : PS1, Line 399: } OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/5dd12432_c254dc48?usp=email : PS1, Line 400: forbiddenProfilePolicyRules [25] PprIds OPTIONAL, -- Tag '99' trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/03f71187_919625eb?usp=email : PS1, Line 401: ppVersion VersionType, -- Protection Profile version trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/d99f24b4_633fb0cf?usp=email : PS1, Line 402: sasAcreditationNumber UTF8String (SIZE(0..64)), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/114714f5_a372c5fa?usp=email : PS1, Line 403: certificationDataObject [12] CertificationDataObject OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/1fc038a5_a0dd1cfc?usp=email : PS1, Line 404: treProperties [13] BIT STRING { trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/5dc9422e_b627985f?usp=email : PS1, Line 405: isDiscrete(0), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/975dc028_e8cdfb27?usp=email : PS1, Line 406: isIntegrated(1), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/b01000ce_66163286?usp=email : PS1, Line 407: usesRemoteMemory(2) -- refers to the usage of remote memory protected by the Remote Memory Protection Function described in SGP.21 [4] trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/f55adbec_037f86be?usp=email : PS1, Line 408: } OPTIONAL, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/c1d53672_0d158c5e?usp=email : PS1, Line 409: treProductReference [14] UTF8String OPTIONAL, -- Platform_Label as defined in GlobalPlatform DLOA specification [57] trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/ac5c2d19_f3e592b2?usp=email : PS1, Line 414: highestSvn [19] VersionType OPTIONAL, -- not used by this version of SGP.32 trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/072fed43_22d1e9ef?usp=email : PS1, Line 415: iotSpecificInfo [20] IoTSpecificInfo OPTIONAL -- mandatory within SGP.32 trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/32a6a773_ccd62bf2?usp=email : PS1, Line 430: AddInitialEimRequest ::= [87] SEQUENCE { -- Tag 'BF57' trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/502783c7_3b4047af?usp=email : PS1, Line 452: resetDefaultSmdpAddress(2), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/46f4330b_379cfbcb?usp=email : PS1, Line 553: fallbackNotAvailable(6), -- Fallback Attribute not set trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/2a9c8348_16925eab?usp=email : PS1, Line 724: invalidEimTransactionId(52), trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/59d9495c_9083b021?usp=email : PS1, Line 808: undefinedError(127) trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/b119b0be_721708d2?usp=email : PS1, Line 812: } trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/38d0e74a_27f74822?usp=email : PS1, Line 813: StateChangeCause ::= INTEGER { trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/8e662a82_dc684cb7?usp=email : PS1, Line 814: otherEim(0), -- for change(s) requested by another registered eIM trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/fae9d3dd_43adde34?usp=email : PS1, Line 815: fallback(1), -- for change(s) following fallback requested by IPA trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/aa9fe882_c1159565?usp=email : PS1, Line 817: local(3), -- for change(s) applied locally (RFU, not supported in this version) trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/1506c49d_4b06a431?usp=email : PS1, Line 819: immediateEnableProfile(5), -- for change(s) following immediate Profile enabling requested by IPA trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/3b43152a_74e5ffc1?usp=email : PS1, Line 821: undefined(127) -- unknown cause trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/393da272_d16280fb?usp=email : PS1, Line 845: undefinedError(127) trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42869/comment/7bd82207_05dfb725?usp=email : PS1, Line 860: profileDownloadTriggerResult [84] ProfileDownloadTriggerResult, -- Tag 'BF54' trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id4d217296f43846aa39f5dc7076465e2dab72a7c Gerrit-Change-Number: 42869 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Jun 2026 11:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
