Review at

host/trxcon/scheduler: modify trx_lchan_tx_func definition

Initially, it was assumed that TX lchan handler will only
compose a burst and return a pointer to the buffer. A burst
itself could be sent somewhere outside, e.g. by caller.

It would be better to send bursts exactly from handler, because
in this case it isn't required to have an external buffer.

Change-Id: Ic9dcdd366e68cec38c5840ed8f8cdda8236d67c7
M src/host/trxcon/sched_trx.h
1 file changed, 1 insertion(+), 1 deletion(-)

  git pull ssh:// refs/changes/12/6712/1

diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index 563ee19..41662e0 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -83,7 +83,7 @@
        uint8_t bid, sbit_t *bits, uint16_t nbits,
        int8_t rssi, float toa);
-typedef ubit_t *trx_lchan_tx_func(struct trx_instance *trx,
+typedef int trx_lchan_tx_func(struct trx_instance *trx,
        struct trx_ts *ts,
        uint32_t fn, enum trx_lchan_type chan,
        uint8_t bid, uint16_t *nbits);

To view, visit
To unsubscribe, visit

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9dcdd366e68cec38c5840ed8f8cdda8236d67c7
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <>

Reply via email to