Attention is currently required from: dexter.

fixeria has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email )

Change subject: esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/esipa_rest_utils.erl:

https://gerrit.osmocom.org/c/onomondo-eim/+/42883/comment/763f12cb_d7e0700a?usp=email
 :
PS1, Line 553:         {ipaEuiccDataResponseError, IpaEuiccDataResponseError} ->
             :
Why don't you just extract the value from a map in-place?
```suggestion
        {ipaEuiccDataResponseError,
         #{ipaEuiccDataErrorCode := IpaEuiccDataResponseError}} ->
```



--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie734a09ed4b0d57de30dc6fb377dfada79ea2ae4
Gerrit-Change-Number: 42883
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to