Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email )
Change subject: common: reset lchan meas state in gsm_ts_release() ...................................................................... Patch Set 1: (1 comment) File src/common/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bts/+/42909/comment/3a16f824_2a68d0ac?usp=email : PS1, Line 344: lchan_meas_reset(lchan); > imho this doesn't belong here, but inside lchan code/FSM triggered by > gsm_lchan_release() above. `gsm_lchan_release()` returns early if `lchan->state == LCHAN_S_NONE` (not active), i.e. it's only resetting the state of active logical channels. I need the meas state to be reset for inactive channels too. I think we can move this `lchan_meas_reset()` call before the `lchan->state == LCHAN_S_NONE` check, so that the meas state is reset regardless of the state. What do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I18dc9d30417b0c5b2e579660d4a087d93445f956 Gerrit-Change-Number: 42909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2026 21:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
