Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42733?usp=email )
Change subject: cosmetic: remove excess linebreaks ...................................................................... Patch Set 1: Code-Review-2 (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/42733/comment/ef1fbdf2_8c0be250?usp=email : PS1, Line 1131: > I think it's useful to sepaate the "main" block from class definitions with > an extra line. […] It's actually recommended in PEP8 to separate top-level classes and methods using two empty lines, see https://peps.python.org/pep-0008/#blank-lines. File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42733/comment/9909f306_26b1f44c?usp=email : PS1, Line 28: > I'm not quite sure what you are trying to achieve here. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2272abcdbba0e57c5118b69bc9398cd909a469b5 Gerrit-Change-Number: 42733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 23:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]>
