Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email )
Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 6: (1 comment) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/5c6c88e1_db64a50c?usp=email : PS6, Line 714: struct cardem_inst *ci = &cardem_inst[i]; I would simply definde a struct with named members at the simtrace protocol level, and then use that struct here to fill those named members. This way it's more or less self-documented, rather than storing things at magic offsets into a byte buffer. that struct could also include a version number so we can later extend/modify it if we ever have more debug info to return? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 18:54:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
