Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters ...................................................................... Patch Set 1: (1 comment) File src/ipa/libipa/ipad.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/48680697_8bd89474?usp=email : PS1, Line 388: IPA_LOGP(SIPA, LERROR, "Unable to emulate retrieval of connectivity patameters.\n"); When I was developing this emulation one of my principles was to move the compatibility logic as far away from the higher layers as possible. I think it is better to put this logic into ipa_es10b_get_conn_params() and return an a normal result with ConnectivityParametersError and undefinedError(127) as error code. You can log the error from inside ipa_es10b_get_conn_params then. However, if you implement it as suggested you cannot return -ENOSUP anymore because you do not know if it is the emulation that returns the error or if it is a real IoT euicc with a real problem. I still would opt for moving the logic into the function as it provides better layer separation. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 15:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
