Attention is currently required from: jolly.

dexter has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965?usp=email )

Change subject: Add close function to HTTP_Server_Emulation
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File library/HTTP_Server_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965/comment/57d29f4c_83d01214?usp=email
 :
PS4, Line 125:  inout HTTPMessage, Close;
I would give the close a separate line.

When I understand this correctly, then the it should be

in Close;

because we currently only receive the Close event from the CLIENT, but the 
CLIENT does not get any Close event back, so its input only. - Correct me if I 
have overlooked something.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42965?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id09976800c7498a7173b5d8911fe545504cfa266
Gerrit-Change-Number: 42965
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jul 2026 12:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to