Attention is currently required from: daniel, lynxis lazus.

dexter has posted comments on this change by daniel. ( 
https://gerrit.osmocom.org/c/pysim/+/43093?usp=email )

Change subject: pysim-smpp2sim: Add support for a TCP connection through proact 
channel
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Patchset:

PS2:
I wonder why the tests are failing with:./pySim-prog_test.sh: line 229: 
pcsc_scan: command not found


File pySim-smpp2sim.py:

https://gerrit.osmocom.org/c/pysim/+/43093/comment/8a8fffac_1dd83a90?usp=email :
PS2, Line 76:     logger.error("%s: connected!" % p)
Is this .error still the correct level?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43093?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idc1f0c75d89ccd879dc9588b7a0b8688b6f76a66
Gerrit-Change-Number: 43093
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 24 Jul 2026 15:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to