Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43102?usp=email )
Change subject: osmo_io: add osmo_iofd_flush() to transmit the pending Tx queue ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Without even looking at the changes and only reading the commit description, I believe this approach is incorrect. Since you cannot anyway guarantee that all remaining data will be written synchronously, and in order to guarantee it you'd need to potentially block, this is not fesabile/appropriate. You need to instead account for the bytes submitted to the iofd, and then calculate how many bytes are enqueued and not yet written through tracking written bytes in the write_cb. See how it's done in osmo-pcap.git ./src/osmo_pcap_wr_file.c local_iofd_write_cb() -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43102?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4e09e91e472a4441977a2c199c07c2cb8005632f Gerrit-Change-Number: 43102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 09:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
