Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 3: (4 comments) File libosmo-trx/include/osmocom/trx/ep.h: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/dbf0aae1_0e92cc2d?usp=email : PS1, Line 27: struct osmo_trx_ep_cfg { > Let's please have separate setter functions for all these, like osmo_stream, > so we don't need to bre […] Done File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/d28c9f25_658f98ca?usp=email : PS1, Line 60: uint8_t pdu_ver; /* TRXD PDU version in use */ > iirc PDU VER stuff is defined/envisioned only for TRX0, so this can be moved > to struct osmo_trx_ep. No. The TRXD PDU version is actually negotiated for each endpoint separately. At least osmo-bts does negotiate the version for each transceiver connection individually, and osmo-trx handles this properly. Only the power on/off command propagates to other connections. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/40c30008_795a1db0?usp=email : PS1, Line 70: struct osmo_trx_ep_chan *chans; /* array of cfg.num_chans channels */ > If the chans array is allocated at the end of the struct, it probably makes > sense to use "struct osm […] See my comment below. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/838ddccf_47a6a862?usp=email : PS1, Line 302: ep->chans = talloc_zero_array(ep, struct osmo_trx_ep_chan, cfg->num_chans); > Ah I see you are allocating the array here as a pointer to a seaprate memory > region. […] I don't see the need for such a premature optimization, sorry. A `struct osmo_trx_ep` is normally allocated once and remains in the memory until the PHY connection is closed. It's not like we're allocating/freeing tons of endpoints per second. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
