dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email )
Change subject: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err
explicitly
......................................................................
eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly
When the testcase responds to the eIM with the error message, the error
code comes from a constant in the template. This means the testcase is
harder to understand and may break if the template changes. Let's set
the error code explcitly to avoid conflicts in the future.
Related: SYS#8100
Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40
---
M eim/eIM_Tests.ttcn
M library/euicc/SGP32Definitions_Templates.ttcn
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/83/43183/1
diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn
index adf5411..a9b127a 100644
--- a/eim/eIM_Tests.ttcn
+++ b/eim/eIM_Tests.ttcn
@@ -995,8 +995,9 @@
eimTransactionId :=
valueof(esipa_res.getEimPackageResponse.ipaEuiccDataRequest.eimTransactionId);
/* Provide a plausible ipaEuiccDataResponse to the eIM */
- f_esipa_transceive(valueof(ts_provideEimPackageResult(eID,
ts_eimPackageResult_euiccDataResp_err(eimTransactionId))),
- tr_provideEimPackageResultResponse_empty);
+ f_esipa_transceive(valueof(ts_provideEimPackageResult(eID,
+ ts_eimPackageResult_euiccDataResp_err(eimTransactionId,
ipaEuiccDataErrorCode := 127))),
+ tr_provideEimPackageResultResponse_empty);
f_rest_lookup_resource(resource_id, "edr", tr_JSON_REST_success(outcome
:= expected_outcome) );
f_rest_delete_resource(resource_id, "edr");
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index 6722e11..ea324d6 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -1508,11 +1508,12 @@
}
}
template (value) EimPackageResult
-ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring
eimTransactionId := omit) := {
+ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring
eimTransactionId := omit,
+ template (value) integer
ipaEuiccDataErrorCode := 127) := {
ipaEuiccDataResponse := {
ipaEuiccDataResponseError := {
eimTransactionId := eimTransactionId,
- ipaEuiccDataErrorCode := 127
+ ipaEuiccDataErrorCode := ipaEuiccDataErrorCode
}
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40
Gerrit-Change-Number: 43183
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
