laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43011?usp=email )

Change subject: SGP32Definitions_Templates: rename 
tr/ts_getEimPackageResponse_eimPkgErrUndef
......................................................................

SGP32Definitions_Templates: rename tr/ts_getEimPackageResponse_eimPkgErrUndef

The template name suffix _eimPkgErrUndef is a bit unflexible. Let's change
it to eimPkgErr and add a parameter erroCode with a default value. This
allows us to use the template with any eimPackageError.

Change-Id: I81b7c3b5ebc8c95d8ea8f1a6030b884ed2efcff3
Related: SYS#8100
---
M ipad/IPAd_Tests.ttcn
M library/euicc/SGP32Definitions_Templates.ttcn
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  jolly: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/ipad/IPAd_Tests.ttcn b/ipad/IPAd_Tests.ttcn
index cf7ff5e..c999cfb 100644
--- a/ipad/IPAd_Tests.ttcn
+++ b/ipad/IPAd_Tests.ttcn
@@ -656,7 +656,7 @@
        f_http_register();

        /* IPAd requests a package, we respond with an eimPackageError code 127 
(undefined error) */
-       f_esipa_transceive(valueof(ts_getEimPackageResponse_eimPkgErrUndef), 
tr_getEimPackageRequest);
+       f_esipa_transceive(valueof(ts_getEimPackageResponse_eimPkgErr(127)), 
tr_getEimPackageRequest);

        /* Wait some time until the the last HTTP response is actually 
delivered */
        f_sleep(2.0);
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn 
b/library/euicc/SGP32Definitions_Templates.ttcn
index c83dc8e..13110ab 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -333,15 +333,15 @@

 /* GSMA SGP.32, section 6.3.2.6 */
 template (present) EsipaMessageFromEimToIpa
-tr_getEimPackageResponse_eimPkgErrUndef := {
+tr_getEimPackageResponse_eimPkgErr(template (present) integer errorCode := ?) 
:= {
        getEimPackageResponse := {
-               eimPackageError := ?
+               eimPackageError := errorCode
        }
 }
 template (value) EsipaMessageFromEimToIpa
-ts_getEimPackageResponse_eimPkgErrUndef := {
+ts_getEimPackageResponse_eimPkgErr(template (value) integer errorCode := 127) 
:= {
        getEimPackageResponse := {
-               eimPackageError := 127
+               eimPackageError := errorCode
        }
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43011?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I81b7c3b5ebc8c95d8ea8f1a6030b884ed2efcff3
Gerrit-Change-Number: 43011
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>

Reply via email to