Attention is currently required from: laforge, pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email )

Change subject: Add test case to verify proper DSCP settings
......................................................................


Patch Set 12:

(3 comments)

Patchset:

PS6:
> The build fails, because it tests a previous patch that depends on library 
> update.
Done


File tests/testsuite.at:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/1bf1edbe_721daf62?usp=email
 :
PS7, Line 32: AT_CHECK([python3 -u 
$abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p 
$abs_srcdir -v TestDSCP],, [ignore], [ignore])
> Ah, I agree. […]
Done


File tests/vty/vty_test_runner.py:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/8d64d6f6_9e0d1817?usp=email
 :
PS11, Line 239:         time.sleep(1.0)
> why is this sleep needed?
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092
Gerrit-Change-Number: 42809
Gerrit-PatchSet: 12
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 11 Aug 2026 09:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to