Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Patchset: PS5: I think I understand it better now. So when we receive the 6cXX from the card. We replay the header, but unless we do not memorize the case from the original transmission the following code assumes that the replay transmission is a case 4 and it indefinitely waits for more data from the terminal. So memorizing the case from the original transmission is how we get around this. Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/a46a16be_70238c09?usp=email : PS3, Line 17: instead of a case 2 with Le != 0. > I am having difficulties to understand this description. […] Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2026 13:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <[email protected]>
