Attention is currently required from: dexter, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email )
Change subject: V1.2: Add function ES10b.EnableEmergencyProfile ...................................................................... Patch Set 6: (3 comments) File include/onomondo/ipa/ipad.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/961d9a4a_99827a87?usp=email : PS3, Line 99: int ipa_enable_emergency_profile(struct ipa_context *ctx); > you can shorten "profile" to "prfle", we used this abbreviation in lots of > other places too. Done File src/ipa/libipa/es10b_en_emerg_prfle.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/bab07ad6_b024cea4?usp=email : PS3, Line 14: struct EnableEmergencyProfileResponse *res; > Also here, it is just an integer that is returned, maybe return it directly > to get an API that is si […] I leave it this way, in case it get expanded. File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/2f087276_845656a5?usp=email : PS3, Line 179: { "enable-emergency-profile", no_argument, NULL, OPT_ENABLEEMGERGENCY}, > See comment from @[email protected] in the previous patch. I think we > should clean this up. Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0304b869a14a36b82cc2d1676b2a5f613e1da171 Gerrit-Change-Number: 43043 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]>
