Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43228?usp=email )

Change subject: sua: fix buffer overflow in sua_parse_gt()
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
> I think it would be prudent to give credit to the reporter of the bug in the 
> commitlog.
Done


File src/sua.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43228/comment/f801c734_65c51342?usp=email
 :
PS1, Line 403:  /* cap num_digits to what fits into gt->digits (leaving room 
for '\0') */
> why silently clamping instead of returning an error?
Acknowledged



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43228?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I59f601f2d8706748797c802f0f09887e4b9ba31f
Gerrit-Change-Number: 43228
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 15:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to